Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accepting request-id as header so services will have the same reqID #34

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

chinmayb
Copy link
Contributor

No description provided.

atlas/templates/cmd/server/main.go.gotmpl Outdated Show resolved Hide resolved
atlas/templates/cmd/server/main.go.gotmpl Outdated Show resolved Hide resolved
@Evgeniy-L
Copy link
Contributor

Toolkit changes are now merged and ExtendedDefaultHeaderMatcher can now be used instead of whitelistStringsHeaderMatcher.

@chinmayb chinmayb requested a review from burov July 10, 2019 06:01
Copy link
Contributor

@burov burov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor comment

atlas/templates/cmd/server/main.go.gotmpl Outdated Show resolved Hide resolved
@chinmayb chinmayb merged commit 03ccf95 into master Jul 11, 2019
@chinmayb chinmayb deleted the chinmayb-patch-2 branch September 9, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants